Abstract: After 2003, some control and guide policies of industrial land have been frequently introduced by China and Shanghai municipal government to contain the spread extensive expansion of industrial land. How is the control effect? Does industrial suburbanization just transfer or bring better land efficiency? Accordance with these problems, the methods of GIS spatial analysis, statistical analysis, marginal efficiency modeling and others are applied to discuss the effects of policy control on industrial land expansion and industrial land efficiency, and then some policy suggestions are given. The results demonstrate that suburb industrial land expansion is obvious in Shanghai and the spatial distribution trends to scatter, industrial land efficiency have improved, but there is still a wide gap compared with foreign developed areas; the driven effect of the industry to parks concentration policy is obvious, industrial suburbanization transfer does not make the industries in the central city declined, and the industries in the suburb does not reflect the corresponding strength, the effects of control policy on industrial land expansion is not good; the marginal efficiency of industrial land presents a decreasing trend by marginal efficiency analysis in Shanghai, and industrial economic growth is still mainly dependent on the increase of industrial land, extensive growth have not been improved effectively.